On Mon, Oct 06, 2025 at 07:09:24AM +0530, Ayushi Makhija wrote:
> Add anx7625 DSI to DP bridge device node.
> 
> Signed-off-by: Ayushi Makhija <[email protected]>
> Reviewed-by: Dmitry Baryshkov <[email protected]>
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 170 ++++++++++++++++++++++
>  1 file changed, 170 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts 
> b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 891e49602c97..5d4040376857 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -24,6 +24,64 @@ chosen {
>               stdout-path = "serial0:115200n8";
>       };
>  
> +     vreg_12p0: vreg-12p0-regulator {

Why are these nodes not in a correct place? Also, why are they named
differently from all other regulators in this board file?

> +             compatible = "regulator-fixed";
> +             regulator-name = "VREG_12P0";
> +
> +             regulator-always-on;
> +             regulator-boot-on;
> +             regulator-min-microvolt = <12000000>;
> +             regulator-max-microvolt = <12000000>;
> +     };
> +
> +     vreg_5p0: vreg-5p0-regulator {
> +             compatible = "regulator-fixed";
> +             regulator-name = "VREG_5P0";
> +
> +             regulator-always-on;
> +             regulator-boot-on;
> +             regulator-min-microvolt = <5000000>;
> +             regulator-max-microvolt = <5000000>;
> +
> +             vin-supply = <&vreg_12p0>;
> +     };
> +
> +     vreg_1p8: vreg-1p8-regulator {
> +             compatible = "regulator-fixed";
> +             regulator-name = "VREG_1P8";
> +
> +             regulator-always-on;
> +             regulator-boot-on;
> +             regulator-min-microvolt = <1800000>;
> +             regulator-max-microvolt = <1800000>;
> +
> +             vin-supply = <&vreg_5p0>;
> +     };
> +
> +     vreg_1p0: vreg-1p0-regulator {
> +             compatible = "regulator-fixed";
> +             regulator-name = "VREG_1P0";
> +
> +             regulator-always-on;
> +             regulator-boot-on;
> +             regulator-min-microvolt = <1000000>;
> +             regulator-max-microvolt = <1000000>;
> +
> +             vin-supply = <&vreg_1p8>;
> +     };
> +
> +     vreg_3p0: vreg-3p0-regulator {
> +             compatible = "regulator-fixed";
> +             regulator-name = "VREG_3P0";
> +
> +             regulator-always-on;
> +             regulator-boot-on;
> +             regulator-min-microvolt = <3000000>;
> +             regulator-max-microvolt = <3000000>;
> +
> +             vin-supply = <&vreg_12p0>;
> +     };
> +
>       dp0-connector {
>               compatible = "dp-connector";
>               label = "DP0";
> @@ -36,6 +94,18 @@ dp0_connector_in: endpoint {
>               };
>       };
>  
> +     dp-dsi0-connector {
> +             compatible = "dp-connector";
> +             label = "DSI0";
> +             type = "full-size";
> +
> +             port {
> +                     dp_dsi0_connector_in: endpoint {
> +                             remote-endpoint = <&dsi2dp_bridge_out>;
> +                     };
> +             };
> +     };
> +
>       regulator-usb2-vbus {
>               compatible = "regulator-fixed";
>               regulator-name = "USB2_VBUS";
> @@ -316,6 +386,70 @@ &gpu_zap_shader {
>       firmware-name = "qcom/qcs8300/a623_zap.mbn";
>  };
>  
> +&i2c8 {
> +     clock-frequency = <400000>;
> +     status = "okay";
> +
> +     io_expander: gpio@74 {
> +             compatible = "ti,tca9539";
> +             reg = <0x74>;
> +             interrupts-extended = <&tlmm 93 IRQ_TYPE_EDGE_BOTH>;
> +             gpio-controller;
> +             #gpio-cells = <2>;
> +             interrupt-controller;
> +             #interrupt-cells = <2>;
> +             reset-gpios = <&tlmm 66 GPIO_ACTIVE_LOW>;
> +
> +             pinctrl-0 = <&io_expander_intr_active>,
> +                         <&io_expander_reset_active>;
> +             pinctrl-names = "default";
> +     };
> +
> +     i2c-mux@70 {
> +             compatible = "nxp,pca9543";
> +             #address-cells = <1>;
> +
> +             #size-cells = <0>;
> +             reg = <0x70>;

compatible
reg

#address-cells
#size-cells


> +

-- 
With best wishes
Dmitry

Reply via email to