On Mon, 07 Jul 2025 09:31:43 +0800, shangyao lin wrote:
> From: "shangyao.lin" <[email protected]>
>
> 1. Add camera isp7x module device document
>
> ---
>
> Changes in v2:
> - Rename binding file to mediatek,mt8188-seninf-core.yaml
> - Various fixes per review comments
> - Update maintainers list
>
> Question for reviewer (CK):
>
> Hi CK,
>
> Thank you for your review and suggestions on this patch, especially for
> providing the reference patch
> (https://patchwork.kernel.org/project/linux-mediatek/list/?series=874617) and
> for mentioning in another patch ([V1,02/10] MEDIA: PLATFORM: MEDIATEK: ADD
> SENINF CONTROLLER) the suggestion to "Move the phy part to phy/mediatek/
> folder. You could refer to phy/mediatek/phy-mtk-mipi-csi-0-5.c".
>
> After reading your comments and the reference patches, my understanding is
> that only the seninf-core driver should manage all ports internally, and each
> port corresponds to a PHY. During probe, the driver will parse each port,
> obtain the corresponding PHY (e.g., devm_phy_get(dev, "csi0"),
> devm_phy_get(dev, "csi1"), etc.), and operate the PHY for each port
> individually during stream on/off or power on/off.
>
> Could you please confirm if my understanding is correct?
> If you have any additional reference patches or examples, I would greatly
> appreciate it.
>
> Thank you for your guidance!
>
> Best regards,
> Shangyao
>
> Signed-off-by: shangyao.lin <[email protected]>
> ---
> .../mediatek/mediatek,mt8188-seninf-core.yaml | 121 ++++++++++++++++++
> 1 file changed, 121 insertions(+)
> create mode 100755
> Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:6:10:
[error] string value is redundantly quoted with any quotes (quoted-strings)
./Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:121:4:
[error] no new line character at the end of file (new-line-at-end-of-file)
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:
properties:clock-names: {'items': [{'const': 'clk_cam_seninf'}, {'const':
'clk_top_seninf'}, {'const': 'clk_top_seninf1'}, {'const': 'clk_top_camtm'}],
'minItems': 4, 'maxItems': 4} should not be valid under {'required':
['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:
properties:clock-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'clk_cam_seninf'}, {'const': 'clk_top_seninf'}, {'const':
'clk_top_seninf1'}, {'const': 'clk_top_camtm'}] is too long
[{'const': 'clk_cam_seninf'}, {'const': 'clk_top_seninf'}, {'const':
'clk_top_seninf1'}, {'const': 'clk_top_camtm'}] is too short
False schema does not allow 4
1 was expected
4 is greater than the maximum of 2
4 is greater than the maximum of 3
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:
properties:reg-names: {'items': [{'const': 'base'}], 'minItems': 1,
'maxItems': 1} should not be valid under {'required': ['maxItems']}
hint: "maxItems" is not needed with an "items" list
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:
properties:reg-names: 'oneOf' conditional failed, one must be fixed:
[{'const': 'base'}] is too short
False schema does not allow 1
hint: "minItems" is only needed if less than the "items" list length
from schema $id: http://devicetree.org/meta-schemas/items.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:
properties:reg: 'anyOf' conditional failed, one must be fixed:
'minItems' is not one of ['maxItems', 'description', 'deprecated']
hint: Only "maxItems" is required for a single entry if there
are no constraints defined for the values.
'minItems' is not one of ['description', 'deprecated', 'const', 'enum',
'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
'maxItems' is not one of ['description', 'deprecated', 'const', 'enum',
'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
1 is less than the minimum of 2
hint: Arrays must be described with a combination of
minItems/maxItems/items
hint: cell array properties must define how many entries and what the
entries are when there is more than one entry.
from schema $id: http://devicetree.org/meta-schemas/core.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml:
$id: Cannot determine base path from $id, relative path/filename doesn't match
actual path or filename
$id: http://devicetree.org/schemas/media/mediatek,seninf-core.yaml
file:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek/mediatek,mt8188-seninf-core.example.dtb:
seninf@16010000 (mediatek,mt8188-seninf-core): reg: [[0, 369164288], [0,
32768]] is too long
from schema $id:
http://devicetree.org/schemas/media/mediatek,seninf-core.yaml#
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
