On 4/14/25 2:14 PM, Dmitry Baryshkov wrote: > On Mon, Apr 14, 2025 at 01:39:56PM +0200, Konrad Dybcio wrote: >> On 4/14/25 1:37 PM, Dmitry Baryshkov wrote: >>> On Mon, Apr 14, 2025 at 01:13:28PM +0200, Konrad Dybcio wrote: >>>> On 3/14/25 7:09 AM, Dmitry Baryshkov wrote: >>>>> From: Dmitry Baryshkov <[email protected]> >>>>> >>>>> Add display controller, two DSI hosts, two DSI PHYs and a single DP >>>>> controller. Link DP to the QMP Combo PHY. >>>>> >>>>> Signed-off-by: Dmitry Baryshkov <[email protected]> >>>>> --- >>>> >>>> [...] >>>> >>>>> + mdss_mdp: display-controller@ae01000 { >>>>> + compatible = "qcom,sar2130p-dpu"; >>>>> + reg = <0x0 0x0ae01000 0x0 0x8f000>, >>>>> + <0x0 0x0aeb0000 0x0 0x2008>; >>>> >>>> size = 0x3000 >>> >>> Existing platforms (including SM8650) use 0x2008 here. Would you like to >>> change all the platforms and why? >> >> The last register is base+0x2004 but the region is 0x3000-sized on 2130 > > As I wrote, this still applies to other existing platforms. I think up > to now we were using a mixture of 'last actual register' and 'documented > space size' with VBIF using the former one. Should we switch all > platforms to use the latter one for this region? In such a case I'll > update this one and all other platforms. Otherwise I'd prefer uniformity > and still use 0x2008 here like other platforms do.
Let's stick to allocated region sizes (i.e. 0x3000 here) Konrad
