On Sat, Jan 07, 2023 at 07:26:23PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg <[email protected]> > > Avoiding direct access to backlight_properties.props. > > Access to the deprecated props.fb_blank replaced by backlight_is_blank(). > Access to props.power is dropped - it was only used for debug.
> Signed-off-by: Sam Ravnborg <[email protected]> > Cc: Stephen Kitt <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Daniel Thompson <[email protected]> > Cc: Andy Shevchenko <[email protected]> > Cc: [email protected] Not sure why you have this (at least) explicitly mentioned as get_maintainer.pl can generate it and git send-email can utilize the script output... ... > - write_reg(par, 0xB5, on ? 0x03 : 0x02); > + write_reg(par, 0xB5, !blank ? 0x03 : 0x02); Why not positive conditional? write_reg(par, 0xB5, blank ? 0x02 : 0x03); -- With Best Regards, Andy Shevchenko
