Hi Stefan,

Thanks for your review!

On 8/20/25 14:47, Stefan Ubbink wrote:
After reading version 06 of draft-huque-dnsop-multi-alg-rules-06 I have
a few small remarks.

They are very much appreciated. If you have any thoughts on whether this draft 
is a good idea or not, they'd also be appreciated! :)

section 2. Proposed Updates to RFCs

In the last paragraph of this section, the algorithms 8 and 13 are mentioned and
it might be useful to add a reference to what these numbers mean. (for example 
https://www.iana.org/assignments/dns-sec-alg-numbers/dns-sec-alg-numbers.xhtml#dns-sec-alg-numbers-1
 )

Thanks, fixed.

section 2.2. Signer Requirements

I think it would be helpful when there is some text to explain what is shown
in table 1, or at least reference the table.

Done!

section  4. Example Scenarios
"various scenariosin practice" -> "various scenarios in practice" (adding a
space)

Done.

section  5. IANA Considerations
"new row is added an the column remains" -> "new row is added and the column
remains" (s/an/and/)

This text has been replaced in the meantime.

section A.2. Validator Requirements
"either validated data (AD=1) or RCODE=2 (SERVFAIL)" -> "either authentic data 
(AD=1) or SERVFAIL (RCODE=2)"
According to RFC4035 section 3, the AD bit stands for Authentic Data. Has this
changed somewhere?
And I think it is more uniform to have the bits between (), so the last part
becomes "SERVFAIL (RCODE=2)"

Thanks, good points! Done.

Your changes have been incorporate here, and will be part of the next revision: 
https://github.com/shuque/draft-dnsop-multi-alg-rules/commit/e41a2b6c92607fb7bdca7a5022367af7465674ae

Best,
Peter

_______________________________________________
DNSOP mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to