Hi Matthew, On Wed, 2026-04-01 at 14:50 -0700, Matthew R. Ochs via dmidecode-devel wrote: > Include EDSFF slots when displaying slot information. > > Signed-off-by: Matthew R. Ochs <[email protected]> > --- > dmidecode.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/dmidecode.c b/dmidecode.c > index 463f12b2748c..cd33ec5458cd 100644 > --- a/dmidecode.c > +++ b/dmidecode.c > @@ -2423,6 +2423,8 @@ static void dmi_slot_information(u8 type, u8 code) > case 0xC2: /* PCI Express 5 */ > case 0xC3: /* PCI Express 5 */ > case 0xC4: /* PCI Express 6+ */ > + case 0xC5: /* EDSFF E1 */ > + case 0xC6: /* EDSFF E3 */ > if (code) > pr_attr("PCI Express Generation", "%u", code); > break;
Thanks for the patch. I originally did not add EDSFF to dmi_slot_information() because the SMBIOS specification only mentions PCI Express for that field. It seems a bit strange to report a "PCI Express Generation" for a non-PCIe slot. And I do not have any example in my large collection of DMI table dumps where this field is set for EDSFF slots. What led you to believe that this field is relevant to EDSFF slots? -- Jean Delvare SUSE L3 Support
