#36368: `makemessages` command runs `write_po_file()` multiple times for the
same
potfile
-------------------------------------+-------------------------------------
Reporter: Michał Pokusa | Owner: Michał
| Pokusa
Type: Bug | Status: assigned
Component: Core (Management | Version: 5.2
commands) |
Severity: Normal | Resolution:
Keywords: makemessages | Triage Stage: Accepted
write_po_file |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by kay):
I came across this bug just this week!
My fix (for the portion that compares `dirname`) would have looked almost
identical, except I named my variable `locale_dir_path` instead of
`locale_dir` to be extra verbose about its contents (vs. `dirname`'s) and
opted to only `insert` matches `not` already in `self.locale_paths` anyway
rather than removing and (re)inserting them.
Good thinking re: the potential for `LOCALE_PATHS` containing `Path`s
rather than strings, Michał, even if that part may have needed to go in a
separate ticket as slightly different (if related) concern.
Is there anything regular users can do to speed up contributions by
others?
--
Ticket URL: <https://code.djangoproject.com/ticket/36368#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070198143a6478-057904c1-aaaa-4256-864c-3abfa8397ba7-000000%40eu-central-1.amazonses.com.
