#36368: `makemessages` command runs `write_po_file()` multiple times for the
same
potfile
-------------------------------------+-------------------------------------
Reporter: Michał Pokusa | Owner: Michał
| Pokusa
Type: Bug | Status: assigned
Component: Core (Management | Version: 5.2
commands) |
Severity: Normal | Resolution:
Keywords: makemessages | Triage Stage: Accepted
write_po_file |
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):
Replying to [comment:11 Michał Pokusa]:
> I have prepared a PR with fix with respect to the order described in
docs and added appropriate tests.
Thank you!
> Is there anything else that needs to be done on my part or should I now
wait for the review on Github?
If you consider the PR ready to be reviewed again, you should ideally
update this ticket's flag so the PR is listed as "needing review" in the
[https://code.djangoproject.com/query?status=!closed&needs_better_patch=0&needs_tests=0&needs_docs=0&has_patch=1&stage=Accepted&desc=1&order=changetime
Django Development Dashboard].
In this specific case, it means that you should unset the "needs test"
flag which was set by a previous reviewer. More docs here:
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#patch-review-checklist
--
Ticket URL: <https://code.djangoproject.com/ticket/36368#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701970dd5c9fe-cff20422-0791-46b7-b688-316f1ae441c2-000000%40eu-central-1.amazonses.com.
