#36488: RedirectView(query_string=True) produces double '?' when both
destination
URL and request have query parameters
-------------------------------+----------------------------------------
Reporter: Ethan Jucovy | Owner: Ethan Jucovy
Type: Bug | Status: assigned
Component: Generic views | Version: 5.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+----------------------------------------
Changes (by Natalia Bidart):
* owner: (none) => Ethan Jucovy
* stage: Unreviewed => Accepted
* status: new => assigned
Comment:
Hello Ethan Jucovy, thank you for taking the time to create this ticket
and the PR. I think your report makes sense, I would also expect `?` and
`&` to be properly handled. Having said that, the current url manipulation
logic feels somehow brittle and I wonder if we should consider a more
robust implementation using urlparse. Have your given this some thought?
--
Ticket URL: <https://code.djangoproject.com/ticket/36488#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070197c2ac7aad-ab0a5e31-562d-4e9d-95ef-4919f79a4f7f-000000%40eu-central-1.amazonses.com.
