#36350: Custom field's db_check() not taken into account when deciding whether
to
recreate constraint.
-------------------------------------+-------------------------------------
Reporter: Baptiste Mispelon | Owner: (none)
Type: Bug | Status: assigned
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Baptiste Mispelon):
* has_patch: 1 => 0
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
* needs_tests: 1 => 0
Comment:
Ah right, I didn't realize that my fix was just doing the `%`-formatting
twice and therefore just turning off the optimization that commit
9953c804a9375956a542da94665662d306dff48d was adding (which explains why CI
was failing on MariaDB). Maybe the fix is not as simple as I first thought
(it was too good to be `True`!).
I'm attaching a patch that adds a failing test (targeting `main`). I tried
to keep it simple but unfortunately it's still fairly verbose (it's quite
hard to test this type of code).
--
Ticket URL: <https://code.djangoproject.com/ticket/36350#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701966bb04bbb-2d446eef-f16c-481a-a150-20efc7248582-000000%40eu-central-1.amazonses.com.
