#36234: Restore single_object argument to LogEntry.objects.log_actions()
------------------------------+-------------------------------------------
Reporter: Adam Johnson | Type: Bug
Status: new | Component: contrib.admin
Version: 5.1 | Severity: Release blocker
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
------------------------------+-------------------------------------------
#36217 dropped the `single_argument` argument in a bug fix release
(5.1.7). Consequently, the method has two signatures in different Django
5.1 versions. I found real-world breakage from this in:
* a client project which had calls to `log_actions()`
* django-import-export - https://github.com/django-import-export/django-
import-export/pull/2045
* django-stubs - https://github.com/typeddjango/django-stubs/blob/master
/django-stubs/contrib/admin/models.pyi#L33 would need changing
I propose that we restore the argument in Django 5.1 and deprecate it from
Django 5.2. It doesn’t make sense that we’d go through the deprecation
pathway for the `log_action()` -> `log_actions()` migration, but drop an
argument in a point release.
--
Ticket URL: <https://code.djangoproject.com/ticket/36234>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701956c49ed25-3887e5c9-f81d-4eb5-8380-36c8336995ed-000000%40eu-central-1.amazonses.com.
