#36234: Restore single_object argument to LogEntry.objects.log_actions()
---------------------------------+----------------------------------------
Reporter: Adam Johnson | Owner: Adam Johnson
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Description changed by Natalia Bidart:
Old description:
> #36217 / [https://github.com/django/django/pull/19214/files#diff-
> d146e5e5e0435a08eb6bf67f501b7b7dc4a28b3aa66caf47f48fe374d9732366L27-L29
> this part of the PR] dropped the `single_argument` argument in a bug fix
> release, 5.1.7. Consequently, the method has two signatures in different
> Django 5.1 versions. I found real-world breakage from this in:
>
> * a client project which had calls to `log_actions()`
> * django-import-export - https://github.com/django-import-export/django-
> import-export/pull/2045
> * django-stubs - https://github.com/typeddjango/django-stubs/blob/master
> /django-stubs/contrib/admin/models.pyi#L33 would need changing
>
> I propose that we restore the argument in Django 5.1 and deprecate it
> from Django 5.2. It doesn’t make sense that we’d go through the
> deprecation pathway for the `log_action()` -> `log_actions()` migration,
> but drop an argument in a point release.
New description:
#36217 / [https://github.com/django/django/pull/19214/files#diff-
d146e5e5e0435a08eb6bf67f501b7b7dc4a28b3aa66caf47f48fe374d9732366L27-L29
this part of the PR] dropped the `single_object` argument in a bug fix
release, 5.1.7. Consequently, the method has two signatures in different
Django 5.1 versions. I found real-world breakage from this in:
* a client project which had calls to `log_actions()`
* django-import-export - https://github.com/django-import-export/django-
import-export/pull/2045
* django-stubs - https://github.com/typeddjango/django-stubs/blob/master
/django-stubs/contrib/admin/models.pyi#L33 would need changing
I propose that we restore the argument in Django 5.1 and deprecate it from
Django 5.2. It doesn’t make sense that we’d go through the deprecation
pathway for the `log_action()` -> `log_actions()` migration, but drop an
argument in a point release.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/36234#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019570cd54d8-9bbf9528-adbc-4230-aca7-373dda95bcb4-000000%40eu-central-1.amazonses.com.
