#36190: High memory usage of CommonPasswordValidator
-------------------------------------+-------------------------------------
Reporter: Michel Le Bihan | Owner: Priyanshu
Type: | Singh Panda
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage: Accepted
CommonPasswordValidator |
Has patch: 0 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):
* resolution: => wontfix
* status: assigned => closed
Comment:
There is often a trade-off between memory usage and performance.
For `CommonPasswordValidator` to compromise on accuracy via a bloom filter
would be backwards incompatible, and therefore, not acceptable without a
strong consensus from the community.
In Django, you can write your own password validators. In this case, a
custom very large file is being used, and so it might make sense to use a
custom validator that uses a bloom filter (to deal with the very large
file). This custom validator could be provided by a third-party package.
Anyone is welcome to discuss this further on the
[https://forum.djangoproject.com/c/internals/5 Django forum].
Note that any PR to improve the current state should not compromise on
accuracy and needs to include performance and memory bench-marking.
--
Ticket URL: <https://code.djangoproject.com/ticket/36190#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070195192940df-936dfde6-0957-4948-a0c9-7e3703437133-000000%40eu-central-1.amazonses.com.
