#36190: High memory usage of CommonPasswordValidator
-------------------------------------+-------------------------------------
Reporter: Michel Le Bihan | Owner: Priyanshu
Type: | Singh Panda
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: 5.1
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
CommonPasswordValidator | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Priyanshu Singh Panda):
Replying to [comment:7 Michel Le Bihan]:
> How will you deal with false positives? Maybe using a sorted array of 64
bit hashes and doing a binary search on it would have a much better lower
FP ratio.
Both approaches seem optimal for handling false positives. I’ve already
set a custom false positive rate for the Bloom filter, which provides a
good balance between memory usage and performance. However, as you
mentioned, using a sorted array of 64-bit hashes with binary search could
further optimize the false positive rate.
Would you recommend switching to this method or keeping the Bloom filter
with the custom FP rate? I can also implement the hash map approach if
needed for further optimization.
Can you let me know how you'd like to proceed, and kindly assign this task
to me.
--
Ticket URL: <https://code.djangoproject.com/ticket/36190#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701951896c566-f4514260-8322-4007-bc01-14263f459ba9-000000%40eu-central-1.amazonses.com.
