#34720: BaseReloader.watch_dir() incorrectly checks for existence of path
-----------------------------+---------------------------------------
Reporter: Josh Thomas | Owner: Josh Thomas
Type: Bug | Status: assigned
Component: Utilities | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+---------------------------------------
Comment (by Mariusz Felisiak):
I have doubts that there is anything to change. It was not crucial for
`watch_dir()` method to check if the path exists. We added `try ...
except` to avoid crashes related with an issue in Python run on some
Docker images (check out #30647), IMO it's still not fixed. `watch_dir()`
is used in `watch_for_translation_changes()` to watch all potential
directories, so actually checking `exists()` may not be desirable.
Moreover, in the past we removed `strict=True` from `Path.resolve()` calls
as it caused permission errors when user didn't have permissions to all
intermediate directories, see e39e727ded673e74016b5d3658d23cbe20234d11.
--
Ticket URL: <https://code.djangoproject.com/ticket/34720#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018967969c71-459ca818-95b8-4d8a-991d-ad4b17c21f87-000000%40eu-central-1.amazonses.com.
