#34720: BaseReloader.watch_dir() incorrectly checks for existence of path
---------------------------+------------------------------------
Reporter: Josh | Owner: nobody
Type: Bug | Status: new
Component: Utilities | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------+------------------------------------
Changes (by Simon Charette):
* component: Uncategorized => Utilities
* stage: Unreviewed => Accepted
Comment:
Looking at #30647 (fc75694257b5bceab82713f84fe5a1b23d641c3f) it seems that
`absolute` actually did raise previously on Python 3.6 at least hence the
wrapping here.
Given `absolute` is not meant to raise in the first place then I think
that calling `.resolve()` explicitly as Jeff pointed out might be the
right way to go here. That should also allow us to remove
[https://github.com/django/django/blob/4a72da71001f154ea60906a2f74898d32b7322a7/tests/utils_tests/test_autoreload.py#L671-L675
the mocking in the test].
Feel free to assign the ticket to you and work on it.
--
Ticket URL: <https://code.djangoproject.com/ticket/34720#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070189661e3998-997e51e2-7735-4292-937e-5feccb038658-000000%40eu-central-1.amazonses.com.
