#30386: Admin foreign key widgets don't quote keys.
-------------------------------------+-------------------------------------
     Reporter:  Joshua Goodwin       |                    Owner:
                                     |  Oluwayemisi Ismail
         Type:  Bug                  |                   Status:  assigned
    Component:  contrib.admin        |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

 > 1. Are you trying to say that the issue is not "Admin foreign key
 widgets don't quote keys" but the issue is that one will not be able to
 add a new pizza ?

 No. There is an original issue from the ticket description, that you can
 see on the attached record
 [https://code.djangoproject.com/attachment/ticket/30386/issue_30386.mp4
 issue_30386.mp4]. Your patch doesn't fix it.

 > 2. Is that the inability to add a new pizza is caused by the issue of
 admin foreign key widgets not quoting keys with special characters

 No. It's a side-effect of [https://github.com/django/django/pull/11280
 patch] proposed by Zeynel, so Zeynel's patch fixes the original issue (see
 issue_30386.mp4) but introduces a regression (see
 issue_30386_with_patch_and_save.mp4​). That's why we couldn't accept it.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30386#comment:20>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701869e59b389-381fbd61-436d-4d22-b912-e21c2229e29b-000000%40eu-central-1.amazonses.com.

Reply via email to