#30386: Admin foreign key widgets don't quote keys.
-------------------------------------+-------------------------------------
Reporter: Joshua Goodwin | Owner:
| Oluwayemisi Ismail
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
> The issue is that you will not be able to add a new pizza with the
proposed patch.
OK, I'm struggle to reproduce this now.
Even at 25b5eea8cdc69a353bb2d22ea2012b09df6c62e4 — which was the reproduce
commit above, with the test project, in Firefox, Edge and Safari, I'm able
to create Pizzas with the Topping `_40` without error. I can't work out
why I'm not seeing this. (Like, did browsers change? 🤔) (
The particular tests from the PRs checking the quoting fail — but pausing
at those points — there's no error saving — i.e. the key isn't quoted but
its working (AFAICS 🤔)
@Yhemisi: given that you're working on this, can you adapt the Selenium
test from the original PR to visit the add a Pizza page and create a new
instance with a topping with e.g. `_40` PK? Does that pass on `main` with
no other changes?
--
Ticket URL: <https://code.djangoproject.com/ticket/30386#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/010701867e1bce28-30b8abd2-031a-465f-8568-eba9500eaaf9-000000%40eu-central-1.amazonses.com.
