#33981: When a DisallowedHost exception is raised, the log message contains an
exception trace
-------------------------------------+-------------------------------------
Reporter: Andrew Selby | Owner: (none)
Type: Uncategorized | Status: closed
Component: Error reporting | Version: 4.1
Severity: Normal | Resolution: wontfix
Keywords: DisallowedHost | Triage Stage:
HTTP_HOST exception trace | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Andrew Selby):
Thanks Carlton,
Now posting on this ticket again in desperate hopes that we finally end up
with the discussion in one place... sigh!
There are places in the framework where there are exception handlers that
serve as a catch-all for exceptions that haven't been able to be handled
at lower level - tracebacks are needed when logs are written from these
locations as they are so general and it's too late to find a clean way to
handle them all. So then, yes, in those cases a traceback in the logs is
very appropriate.
But for SuspiciousOperation, this is a handled exception, handled cleanly
and specifically. When an exception is handled cleanly and specifically,
the probability that you want a traceback is low. So why would you
generate a traceback for this well handled exception? That just has the
effect of potentially distracting from any other more urgent tracebacks.
So, I'm still arguing for removing this specific traceback as a net-
positive :)
Thanks for advice on appropriate routes forward, much appreciated.
--
Ticket URL: <https://code.djangoproject.com/ticket/33981#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018312fda7e2-840faf2e-d800-4abf-9ac6-32c5138e4efe-000000%40eu-central-1.amazonses.com.
