#33981: When a DisallowedHost exception is raised, the log message contains an
exception trace
-------------------------------------+-------------------------------------
Reporter: Andrew Selby | Owner: (none)
Type: Uncategorized | Status: closed
Component: Error reporting | Version: 4.1
Severity: Normal | Resolution: wontfix
Keywords: DisallowedHost | Triage Stage:
HTTP_HOST exception trace | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Andrew Selby):
Ok, so now I know comments on this ticket are still being read post
closure - this is my first time creating a Django PR, so I'm still
familiarizing myself with the nuances of how the system works. I'll put
all future correspondence on this ticket.
I'm not sure that you understand my proposed change. I've made a change
that **removes** the unnecessary exception trace from the logs, while
**maintaining** the additional exception type testing, so I don't see a
rationale to close the ticket.
Requiring a user to write a custom formatter in order to eliminate an
exception trace dump from the logs is, in my view, a useability mistake.
My PR would be a better solution, since it maintains test functionality
and avoids unnecessary exceptions in the logs.
Would you please reopen the ticket.
Replying to [comment:5 Carlton Gibson]:
> Given the pre-existing discussion, I see no reason to change. Agreement
on the DevelopersMailingList would be the way forward, but a custom
formatter is the correct solution.
>
>
> > I think you'll find that my changes protect the intent of the original
PR, …
>
> I take it that the previous intent was exactly to add the exception
details, so I don't really see this is correct.
--
Ticket URL: <https://code.djangoproject.com/ticket/33981#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018312d0df0a-77069247-025e-4944-a0b1-d4f233e916be-000000%40eu-central-1.amazonses.com.
