#33456: Make underscore in hostname error more explicit
-------------------------------------+-------------------------------------
Reporter: kimsia | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: HTTP handling | Version: 3.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by kimsia):
* has_patch: 0 => 1
Old description:
> Currently, the error message is simply
>
> "The domain name provided is not valid according to RFC 1034/1035."
>
> Most tickets filed against this topic is about how underscores should be
> allowed. I agreed with Django's choice to invalidate underscores.
>
> https://github.com/django/django/pull/594 explains this clearly.
>
> However, the error message can be clearer.
>
> I recommend when underscore is detected, simply make it more explicit
>
> " %r contains _ and that is not valid according to RFC 1034/1035." %
> domain
>
> Otherwise, "The domain name provided is not valid according to RFC
> 1034/1035."
New description:
Currently, the error message is simply
"The domain name provided is not valid according to RFC 1034/1035."
Most tickets filed against this topic is about how underscores should be
allowed. I agreed with Django's choice to invalidate underscores.
https://github.com/django/django/pull/594 explains this clearly.
However, the error message can be clearer.
I recommend when underscore is detected, simply make it more explicit
" %r contains _ and that is not valid according to RFC 1034/1035." %
domain
Otherwise, "The domain name provided is not valid according to RFC
1034/1035."
Patch: https://github.com/django/django/pull/15343
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33456#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.ecc95bf72df2a9974638e717eefda11d%40djangoproject.com.
