#33456: Make underscore in hostname error more explicit
------------------------------------------------+------------------------
               Reporter:  kimsia                |          Owner:  (none)
                   Type:  Cleanup/optimization  |         Status:  new
              Component:  Error reporting       |        Version:  3.2
               Severity:  Normal                |       Keywords:
           Triage Stage:  Unreviewed            |      Has patch:  0
    Needs documentation:  0                     |    Needs tests:  0
Patch needs improvement:  0                     |  Easy pickings:  0
                  UI/UX:  0                     |
------------------------------------------------+------------------------
 Currently, the error message is simply

 "The domain name provided is not valid according to RFC 1034/1035."

 Most tickets filed against this topic is about how underscores should be
 allowed. I agreed with Django's choice to invalidate underscores.

 https://github.com/django/django/pull/594 explains this clearly.

 However, the error message can be clearer.

 I recommend when underscore is detected, simply make it more explicit

 " %r contains _ and that is not valid according to RFC 1034/1035." %
 domain

 Otherwise, "The domain name provided is not valid according to RFC
 1034/1035."

-- 
Ticket URL: <https://code.djangoproject.com/ticket/33456>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/052.3f87c2d06fe9c9b485dbd7b10c16fb0b%40djangoproject.com.

Reply via email to