While testing this, I ran into a shortcoming with the fallback strategy for
backwards-compatibility.
If you have a DjangoTemplates backend configured with 'APP_DIRS': True (as
in the tutorial) and you try to visit /admin/auth/user/#/change/ which
renders the ReadOnlyPasswordHashWidget, the template system will crash with
TemplateDoesNotExist because it can find the widget's template using the
app_directories loader but not the 'django/forms/widgets/attrs.html'
template that the first template includes. Since the first template is
found using what's configured in TEMPLATES (which doesn't know about any of
the built-in form templates), the standalone engine needed to find the
built-in templates is ignored.
I guess it will affect every project that uses the admin. I can't think of
a simple solution other than adding a system check upgrade warning to
detect this situation ('django.contrib.admin' in INSTALLED_APPS but not
'django.forms') and advise the user to add 'django.forms' to
INSTALLED_APPS. Thoughts?
On Thursday, May 12, 2016 at 1:17:23 PM UTC-4, Carl Meyer wrote:
>
> On 05/12/2016 09:39 AM, Tim Graham wrote:
> > So this discussion doesn't stall the rest of the patch, I suggest
> > keeping the fallbacks for now and deprecation them later if they cause
> > confusion or other problems.
>
> Yes, I think that makes sense.
>
> Carl
>
>
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/2fa7c726-3549-4a02-a820-0aae79802a2c%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
