So this discussion doesn't stall the rest of the patch, I suggest keeping the fallbacks for now and deprecation them later if they cause confusion or other problems.
On Wednesday, May 11, 2016 at 2:08:31 PM UTC-4, Carl Meyer wrote: > > On 05/11/2016 11:52 AM, Carl Meyer wrote: > > On 05/11/2016 11:30 AM, Tim Graham wrote: > >> What's your proposal for changing the default TEMPLATES? Using Jinja2 > or > >> DTL? > > > > At some point maybe we can adopt Jinja2 as a required dependency. Until > > then, the default startproject template can't use it, so I think DTL is > > the only real option. > > Oops, I should clarify here that I don't actually plan to change the > default TEMPLATES setting at all; we don't need to. The default > startproject TEMPLATES already includes an engine with APP_DIRS: True; I > would just add 'django.forms' to the default INSTALLED_APPS. > > But even that only really makes sense if we're planning to deprecate the > automatic fallback to the built-in templates, so we want to push people > to configure their settings to explicitly include them. If we plan to > leave the fallback around permanently, there's no need to change the > startproject template at all. > > Here are the pros and cons as I see them for deprecating the fallback > (all the pros apply only after the deprecation process would complete): > > - pro: cleaner and simpler default TemplateRenderer, with less complex > code and tests to maintain. > > - pro: simpler mental model of form template rendering, where the form > templates work just like any other kind of template, they aren't > magically always available. > > - con: requires an update to settings (for most projects, just adding > 'django.forms' to INSTALLED_APPS) to keep forms rendering as they do now > (once the deprecation process completes). > > I like conceptual simplicity, and I care more about where we end up than > about what the deprecation path requires (IMO the "con" in that list > disappears once everyone has upgraded through the deprecation process, > whereas the "pros" are permanent), so I lean towards deprecating the > fallback, but I really don't feel strongly about it at all. Claude > prefers keeping the fallback around permanently. What do others think? > > Carl > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/4c27261f-5c08-4ac6-a6e3-4128a49f52d9%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
