Hi Erik, Am Sun, 8 Mar 2015 15:47:27 +0100 schrieb Erik Romijn <[email protected]>: > I've taken another stab at 16860[1]: having a password > validation/policy in Django. I've made an initial simple PR[2] to > show the approach I'd like to use - no tests or documentation yet, > the example validators are not very nice, possibly bad naming, etc. > But this should be sufficient to show how I would like to tackle > this. There's quite a few decisions to take, influencing the later > possibilities, which I'll try to outline below.
I really like this a lot, both the idea of the ticket and the way you're proposing to implement it. However, I'm not quite sure whether I like the style you chose to pass constructor arguments in the PASSWORD_VALIDATORS setting you proposed. I believe it might be worth considering to design the PASSWORD_VALIDATORS setting in a similar fashion to the new TEMPLATES setting. I understand why you chose this style and it might really be the best way to do this one thing, but I fear it adds complexity because it behaves differently than all other settings variables and thus makes it harder to remember how Django's settings work. Raphael -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/20150308172841.3775a4df%40kvothe. For more options, visit https://groups.google.com/d/optout.
pgpI3LsGgFZcH.pgp
Description: Digitale Signatur von OpenPGP
