On Wed, Aug 29, 2012 at 2:01 PM, ptone <pres...@ptone.com> wrote: > > > On Saturday, August 25, 2012 5:32:08 PM UTC-7, Russell Keith-Magee wrote: >> >> On Sat, Aug 25, 2012 at 4:24 PM, Aymeric Augustin >> <aymeric....@polytechnique.org> wrote: >> > On 25 août 2012, at 10:15, Russell Keith-Magee wrote: >> > >> >> We *could* just mark the affected tests that require auth.User as >> >> "skipUnless(user model == auth.User)", but that would mean some >> >> projects would run the tests, and some wouldn't. That seems like an >> >> odd inconsistency to me -- the tests either should be run, or they >> >> shouldn't. >> > >> > FWIW it doesn't seem odd to me. If a project doesn't use Django's >> > built-in User model then you don't need to test it in that project's >> > test suite. >> >> A possible miscommunication here -- I don't think it's odd that the >> tests wouldn't be run; I only think it would be odd to have those >> tests report as "skipped". It feels to me like they should be either >> run or not run, not reported as skipped. > > > Isn't it just semantic nuance at that point? Seems like not a heap of > distinction between "not run" vs "skipped" when a condition isn't met such > that the test would be applicable.
I suppose you could see it as a semantic nuance. However, to my mind, there is a different. A skipped test is something that could -- or even *should* be run -- but can't due to missing some optional prerequisite. In this case, we're talking about tests that can't ever be run. To my mind, it doesn't make sense to have those tests present but "skipped". Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
