On Sat, Aug 25, 2012 at 4:24 PM, Aymeric Augustin <aymeric.augus...@polytechnique.org> wrote: > On 25 août 2012, at 10:15, Russell Keith-Magee wrote: > >> We *could* just mark the affected tests that require auth.User as >> "skipUnless(user model == auth.User)", but that would mean some >> projects would run the tests, and some wouldn't. That seems like an >> odd inconsistency to me -- the tests either should be run, or they >> shouldn't. > > FWIW it doesn't seem odd to me. If a project doesn't use Django's > built-in User model then you don't need to test it in that project's > test suite.
A possible miscommunication here -- I don't think it's odd that the tests wouldn't be run; I only think it would be odd to have those tests report as "skipped". It feels to me like they should be either run or not run, not reported as skipped. > Indeed, running django.contrib.* tests within a project can fail in > a variety of interesting ways. Trying to isolate them sufficiently > is an endless quest. Generally speaking, I like the idea to identify > various types of test. The only downside I can imagine is the risk > that some categories lose meaning over time, leading to situations > similar to modeltests vs. regressiontests today. Completely agreed. The bug tracker is filled with dozens of bugs (both open and closed) that follow the pattern of "this test can't pass if X is/isn't in settings". I'm not so concerned about the proliferation/confusion of categories, however. To my mind, there's only 2 types of tests that really matter. * Internal checks of system functionality. These need to run against a clean set of known settings. There might be multiple tests for different configurations (e.g., run this test when a cache backend is defined; now run it when a cache backend is *not* defined); but ultimately this is just "run with known settings", for different values of "known". * Integration tests. These need to run against against the currently active project settings. Others may want to add other categories (like the smoke and interaction tests that I mentioned), but we can accommodate that by providing flexibility -- we don't have to use them ourselves. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
