Hi Yohan. On 03/08/2012 07:04 AM, Yohan Boniface wrote: > Some great changes have been made on the admin for this release. One of > them is the add of the "get_inline_instances" [1], that gives the > possibility to change the inlines list at runtime. > > I've a little suggestion on this. It could be really more powerful if to > this method get passed the "obj" parameter, like for example it's done > for get_fieldsets [2]. > > For what I can see, this seems to be a very soft change. > > The function is called three times in options.py. > One is in get_formsets [3], and get_formsets itself has the "obj" > parameter. > Another is in the add_view [4], and here obj could have its default > value, None, as we are in add view and so no object exists. > The last is in the change_view [5], which retrieve the "obj" from its > own parameters.
I think this is a sensible change. > Do you think this change is enough minor to be added in the 1.4 release > process? Unfortunately, no. This is a new feature, which means it was too late to add it as soon as the beta was released, let alone after the RC. (After the RC we're hesitant to even fix bugs unless they are release-blocking bugs). This is too bad, because once 1.4 is released there will have to be consideration of backwards-compatibility for existing "get_inline_instances" methods that don't accept the "obj" parameter. This may tip the scales towards considering this not worth doing, depending what compelling use cases can be presented. Feel free to file a bug for this and it can be revisited after 1.4 is released. Carl
signature.asc
Description: OpenPGP digital signature
