Hi,
First of all, congrats to the core team for the first rc of the 1.4 release!
Some great changes have been made on the admin for this release. One of
them is the add of the "get_inline_instances" [1], that gives the
possibility to change the inlines list at runtime.
I've a little suggestion on this. It could be really more powerful if to
this method get passed the "obj" parameter, like for example it's done
for get_fieldsets [2].
For what I can see, this seems to be a very soft change.
The function is called three times in options.py.
One is in get_formsets [3], and get_formsets itself has the "obj" parameter.
Another is in the add_view [4], and here obj could have its default
value, None, as we are in add view and so no object exists.
The last is in the change_view [5], which retrieve the "obj" from its
own parameters.
Do you think this change is enough minor to be added in the 1.4 release
process?
If yes, just tell me if I need to create a ticket and a patch. :)
But maybe, I've missed something! :s
Thanks for all, django guys!
Yohan
[1]
https://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L348
[2]
https://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L425
[3]
https://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L508
[4]
https://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L936
[5]
https://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L1034
--
You received this message because you are subscribed to the Google Groups "Django
developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en.
