On 16 févr. 2012, at 23:35, Reinout van Rees wrote: > I didn't realize that I could mark it "ready for check-in" myself. (But there > are 35 tickets ready for check-in, so I guess I still need to bug people to > get it to be actually checked in).
That's mostly the consequence of a sprint that happened two weeks ago, and last I looked, many of these weren't really "ready for check-in" -- often it isn't obvious why the patch is the correct solution. Tickets with a good patch and a good explanation in the comments usually get committed quickly. > Partially related question: several tickets have a pull request on github > instead of an svn patch. Is that enough? I assume a real svn patch is better? The most important thing is to tick the "has patch" checkbox so the ticket appears in the list of tickets needing review. As far as I am concerned, https://gist.github.com/1170400 abstracts the difference between a patch and a pull request :) Best regards, -- Aymeric. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
