Couple questions: I see a variable saved_objects being written, but I don't see it being accessed -- is this to ease future features, or am I missing a code path?
If I'm reading correctly, check_for_invalid_foreign_keys extends over all the rows in a table. loaddata is called by syncdb and South's migrate, not just when a db is set up, so this could easily wind up run over lots and lots of non-fixture data. I don't know MySQL's performance characteristics that well -- is this likely to be expensive? Thanks very much for the patch -- managing dependencies in fixtures is a pain, and it'll be nice not to worry about it. -Mike On Mon, Jun 27, 2011 at 5:14 PM, Jim Dalton <jim.dal...@gmail.com> wrote: > On Jun 27, 2011, at 4:52 PM, Russell Keith-Magee wrote: > > > Unfortunately, not much. Your test has validated that the extra code > > doesn't break anything under MyISAM, and this is certainly useful. > > However, the root problem only exists with InnoDB because of its... > > eclectic... implementation of row level constraints. MyISAM doesn't > > have constraints, so your test hasn't exercised the part of the code > > that needs to be exercised heavily. > > One unintended benefit of the current patch is that it actually will (if > I'm not mistaken) check for invalid foreign key references in MyISAM as > well, since the check is run for all MySQL implementations (though not for > any other backends). So MyISAM would normally silently allow bad foreign > keys to be loaded from your fixture data, but with the patch you'll now get > an error. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
