nitpick: I got a few complaints about trailing whitespace when I applied:

/home/mike/sqlpatch.diff:36: trailing whitespace.

/home/mike/sqlpatch.diff:42: trailing whitespace.

/home/mike/sqlpatch.diff:126: trailing whitespace.

/home/mike/sqlpatch.diff:148: trailing whitespace.

/home/mike/sqlpatch.diff:212: trailing whitespace.



On Mon, Jun 27, 2011 at 3:37 PM, Jacob Kaplan-Moss <ja...@jacobian.org>wrote:

> On Mon, Jun 27, 2011 at 5:27 PM, Jim D. <jim.dal...@gmail.com> wrote:
> > Does it work in production is a hard question for me to answer, if I
> > understood your question properly. In my projects, I really only touch
> the
> > loaddata command when I'm running tests (I guess loading data via
> > initial_data.json into a production DB sort of counts as running in
> > production). I don't think anything in my proposed changes touches
> > production code with possibly a few minor exceptions. I know that I can
> run
> > the full Django test suite with MySQL in innodb and I do not get any
> fixture
> > loading issues related to forward references.
>
> Yeah, sorry -- I wasn't precise enough with my language. I meant
> "works with a real-world project" -- since I don't use MySQL, I can't
> test this out at all. So I need to rely on other people to tell me
> "yeah, works fine."
>
> > It'd be great if some others could test this patch out as well. In
> > particular, I can't be sure how well ti works on older versions of MySQL.
> > There's no crazy magic at work here but, well, you never know.
>
> Mmhhm, that's a big one. This *is* MySQL we're talking about... :)
>
> > If it works for others and we're all in agreement with the philosophical
> > approach of the solution, I think it should be a fairly uncontroversial
> > commit, since it's really primarily a fixture loading issue at its core.
>
> If I get a couple-three reports of "worksforme" and if we can pin down
> that this works with all the well-supported MySQL versions -- 4.1+,
> essentially -- that's enough for me.
>
> Jacob
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers" group.
> To post to this group, send email to django-developers@googlegroups.com.
> To unsubscribe from this group, send email to
> django-developers+unsubscr...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/django-developers?hl=en.
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to