On 05/05/11 20:12, Dave McLain wrote: > I have apologized on #django-dev as well, but I do feel like I ought to > throw my mea culpa up here as well for posterity. I misread Jacob's "I > think this is a great idea" to mean "Go ahead and set 'Patch needs > Improvement'" on 100 tickets rather than what I should have read "Some > method of automatically checking patches and giving some feedback, but > without spamming the world would be great". > > I let my enthusiasm get the best of me and as penance I'll spend some > hours trying to get some of the patches that I just let a script say > need improvement to apply cleanly.
>From my point of view, there's no need to do that. There are many patches that we basically have to consider 'abandoned' - if the original author doesn't keep them up to date, they can't expect anyone else to. I'd redirect your sense of guilt elsewhere :-) However, I agree with Jannis that marking many old patches as needing improvement in this way is not always helpful. If a patch hasn't been reviewed by a human, it could be frustrating to be told that it doesn't apply to trunk, then update it, when it never stood a chance anyway because 1) no human was actually bothered about it or 2) the approach was all wrong, and that could have been seen by a manual review, *before* saying that it doesn't apply. And then there is the issue of overwhelming people with spam. I do think this could be useful though. If someone submits a patch that *immediately* doesn't apply to trunk, then it will be useful to know that, and hooking this in to Trac at the point the patch is uploaded would be useful. So, given that you've already dealt with the complete backlog, although it was a bit of a deluge, that shouldn't happen again, so it might not be a bad idea to keep it on going forward. There may also be the possibility of leaving the comments, but not triggering the e-mails. If patchhammer has admin rights to Trac, it could use the batchmodify plugin, which would allow that. Luke -- "My middle name is 'Organised'! My first name is 'Poorly'." Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
