On 27.10.2010, at 09:46, SmileyChris wrote:

> On Oct 27, 5:35 am, Łukasz Rekucki <lreku...@gmail.com> wrote:
>> I would like to bring this up again, because this is something that
>> would really improve readability of my templates. I'm mainly
>> interested in ticket #7817 (the include tag changes), but extending
>> "with" tag (ticket 9456) would keep things consistent.
> 
> Here's a link to the ticket for the lazier ones among us:
> http://code.djangoproject.com/ticket/7817
> 
> The main decision which needs to be made is one of syntax.
> 
> The current proposal uses:
> {% include "name_snippet.html" with name="Joe" greeting="Hello" %}
> but this introduces an inconsistency with the {% with %} tag.

I'm feeling strongly against moving from the "value as name" to the 
"name=value" notation, since I think the former is actually more readable than 
the latter for the targetted audience (template authors).

> Consistency would be nice, but I think this starts to look a bit
> confusing, static tokens outnumbering actual functional ones:
> {% include "name_snippet.html" with name as "Joe" and greeting as
> "Hello" %}

Well, I think that's actually not a bad notation at all (if using the correct 
order :), so for #7817 I propose the following syntax (as analogously proposed 
by #9456 for {% with %}):

{% include "name_snippet.html" with "Joe" as name and "Hello" as greeting %}


Jannis

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to