On Tue, Mar 31, 2009 at 2:57 PM, Vinicius Mendes | meiocodigo.com < vbmen...@gmail.com> wrote:
> > Joseph, > > I think the problem is still the same of the reported in the ticket, > since the reporter talks about inlineformset_factory, so he is using > InlineFormsets. > > Did you see the patch I put in dpaste? http://dpaste.com/21753/ It's > basically the same idea used in the changeset. > > On Mar 31, 3:35 pm, Joseph Kocherhans <jkocherh...@gmail.com> wrote: > > On Tue, Mar 31, 2009 at 12:32 PM, Vinicius Mendes <vbmen...@gmail.com > >wrote: > > > > > In the ticket description, the user says that he is using > > > inlineformset_factory, so do I. The changeset only fixes the FormSet. > > > ModelFormSet and InlineFormSet are still bugged. In the methods > > > save_new_objects and save_existing_objects, you have to check if the > form is > > > marked for deletion, if so, delete the object or don't save it (in case > of > > > saving new objects). > > > > > The framework is checking if the form is marked for deletion in > > > cleaned_data, but the cleaned_data isn't created for invalid forms. I > wrote > > > a patch to solve this problem and was thinking about reopening the > ticket, > > > but always, when somebody reopens a ticket in the TRAC, commiters ask > him to > > > send an e-mail to de developers list. > > > > > What do you think about reopening the ticket? > > > > You're right. The changeset only fixes plain formsets, not model formsets > or > > inline formsets. Normally, I'd say open a new ticket since it's a > different > > problem, but I'll work on a patch right now. A new ticket would just be > > extra bookkeeping. > > I didn't understand, you think is better reopen the ticket, open a new > ticket or don't do anything? > > > > > Joseph > > > Joseph was saying to not bother either opening a new ticket or reopening that since he's working on it right now. Alex -- "I disapprove of what you say, but I will defend to the death your right to say it." --Voltaire "The people's good is the highest law."--Cicero --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
