On Tue, Mar 31, 2009 at 1:55 PM, Vinicius Mendes | meiocodigo.com < vbmen...@gmail.com> wrote:
> > Look at this link: > > http://code.djangoproject.com/browser/django/trunk/django/forms/formsets.py > > I think your revision isn't the HEAD of trunk. The comment you said is > in lines 227-229. But the point here isn't create a cleaned_data for > the form. I know it will not exist. The problem is that this will > cause problems in lines 428 and 447 of models.py ( > http://code.djangoproject.com/browser/django/trunk/django/forms/models.py > ). I wrote a little patch, if you want to take a look, you will > understand what I am saying. The diff is here: > > http://dpaste.com/21753/ > > On Mar 31, 2:41 pm, Alex Gaynor <alex.gay...@gmail.com> wrote: > > On Tue, Mar 31, 2009 at 1:39 PM, Vinicius Mendes | meiocodigo.com < > > > > > > > > vbmen...@gmail.com> wrote: > > > > > I didn't understand. Line 216 is the docstring: > > > > > """ > > > Returns True if form.errors is empty for every form in self.forms. > > > """ > > > > > I don't want to create the cleaned data. I just adopted the same logic > > > used in the patch to solve the problem. If the form doesn't have a > > > cleaned_data attr, so I get it from the field, and check it. All the > > > changes were made in the django/forms/models.py In the methods > > > save_existing_objects and save_new_objects. > > > > > On Mar 31, 2:35 pm, Alex Gaynor <alex.gay...@gmail.com> wrote: > > > > On Tue, Mar 31, 2009 at 1:32 PM, Vinicius Mendes <vbmen...@gmail.com > > > > > wrote: > > > > > In the ticket description, the user says that he is using > > > > > inlineformset_factory, so do I. The changeset only fixes the > FormSet. > > > > > ModelFormSet and InlineFormSet are still bugged. In the methods > > > > > save_new_objects and save_existing_objects, you have to check if > the > > > form is > > > > > marked for deletion, if so, delete the object or don't save it (in > case > > > of > > > > > saving new objects). > > > > > > > The framework is checking if the form is marked for deletion in > > > > > cleaned_data, but the cleaned_data isn't created for invalid forms. > I > > > wrote > > > > > a patch to solve this problem and was thinking about reopening the > > > ticket, > > > > > but always, when somebody reopens a ticket in the TRAC, commiters > ask > > > him to > > > > > send an e-mail to de developers list. > > > > > > > What do you think about reopening the ticket? > > > > > > > -------- > > > > > > > Vinícius Mendes > > > > > Engenheiro de Computação > > > > > Meio Código - A peça que faltava para o seu código! > > > > > URLhttp://www.meiocodigo.com > > > > > > Look at line 216 of formsets.py it specifically makes sure not to > > > interogate > > > > cleaned_data. > > > > > > Alex > > > > > > -- > > > > "I disapprove of what you say, but I will defend to the death your > right > > > to > > > > say it." --Voltaire > > > > "The people's good is the highest law."--Cicero > > > > Not the line 216 i see, but to save trouble here's the full comment: > > > > 215 # The way we lookup the value of the deletion field > here > > takes 216 # more code than we'd like, but the form's > > cleaned_data will 217 # not exist if the form is invalid. > > > > Alex > > > > -- > > "I disapprove of what you say, but I will defend to the death your right > to > > say it." --Voltaire > > "The people's good is the highest law."--Cicero > > > No, my comments weren't directed at trunk, but neither was the commit you referenced. You'll need a failing test case(probably just trying to call save on a formset like the ones in the tests). Alex -- "I disapprove of what you say, but I will defend to the death your right to say it." --Voltaire "The people's good is the highest law."--Cicero --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
