On 2/11/06, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > Now that the dust has settled on the descriptor work, I've turned back > to bulk delete. > > I've attached a new patch to the original ticket - > http://code.djangoproject.com/ticket/1219 - which is updated to > reflect the descriptor changes.
This change, at a glance, looks good. Go ahead and commit it. As for renaming all() to cached() and/or making SomeModel.objects a QuerySet directly and having to deal with cached vs. non-cached query sets -- we've already had this discussion, decided on it and moved on. It's SomeModel.objects.all(), and there's no having to mess with cached vs. non-cached query sets. The way it's currently handled in magic-removal is great, and a fine improvement. Let's move forward. Adrian -- Adrian Holovaty holovaty.com | djangoproject.com | chicagocrime.org
