Robert Wittams wrote: > Adrian Holovaty wrote: > > > > This change, at a glance, looks good. Go ahead and commit it. > > > > As for renaming all() to cached() and/or making SomeModel.objects a > > QuerySet directly and having to deal with cached vs. non-cached query > > sets -- we've already had this discussion, decided on it and moved on. > > It's SomeModel.objects.all(), and there's no having to mess with > > cached vs. non-cached query sets. The way it's currently handled in > > magic-removal is great, and a fine improvement. Let's move forward. > > > > Adrian > > The name 'objects' was predicated on the manager being a query set and > really makes very little sense anymore. It isn't a collection of > objects, its just some arbitrary thing that happens to have a method > that returns a query set... right?
FWIW I also find 'all' a bit ugly. It's not so bad in Python. My objection is the point that Luke has raised: template authors shouldn't be bothered by it. It is such a common operation in Django templates to want to iterate over a set of objects that it seems worth making the syntax as nice as possible. Kieran
