On a somewhat related note, how should I handle something like this? https://github.com/gershwin-desktop/libs-gui/blob/master/Source/NSApplication.m#L1356-L1396
This code allows the GWorkspace dock to act like a Gnome style dock so I can minimize applications, and instantly raise all of them by clicking an app icon in a dock. Would putting it behind a a new default make sense? I am more than sure this would need more rework in a review. It was a quick hack to the best of my abilities so far. Or should I just keep this sort of thing in a a fork for Gershwin? I am open to either strategy. I realize touching libs-gui can break a lot of critical functionality if implementations are not proper, and I don't want to break GNUstep either. Joseph Maloney Sent with [Proton Mail](https://proton.me/mail/home) secure email. On Monday, July 14th, 2025 at 5:51 AM, richard <[email protected]> wrote: > I agree. My recollection is that the interface styles are used primarily for > changes of 'feel' rather than of 'look': ie to alter behaviour rather than > appearance. > > And yes, a theme can/should set the 'enter' image to be a completely > transparent image if we don't want a visible icon. > > The awkward case would be where we want to see an enter icon on enter buttons > in some contexts but not in others ... That sort of fine-grained > customisation is normally achieved by a theme loading code which overrides > specific methods. > >> On 14 Jul 2025 at 12:29, Riccardo Mottola <[email protected]> wrote: >> >> Hi, >> >> Fred Kiefer wrote: >> >>>> Show "Enter" icon in default button only if NSInterfaceStyle is >>>> NSNextStepInterfaceStyle or GSWindowMakerInterfaceStyle. >> >>>> That icon looks alien in other interface styles such as >>>> NSMacintoshInterfaceStyle: >> >>> The code look fine for me. I just wanted to raise the issue here to see if >>> there are any objections or improvement suggestions. Otherwise I will merge >>> this in a few days. >> >> I don't like it as it is done. I like the concept of being able to >> >> customzie those buttons, however this "That icon looks alien in other >> >> interface styles such as NSMacintoshInterfaceStyle" is wrong in my >> >> opinion. It is only true in the sense that a "macinthosh" doens't use >> >> the enter key but has a focus ring (that is, it marks the enter button >> >> differently). However "NSMacintoshInterfaceStyle" refers more to the >> >> borad generic style: like top-menu and other details, not "clone mac". >> >> A bit like WindowsStyle is at the end used for GTK or could be used for QT. >> >> Just my opinion, maybe I should comment on the tread to find an >> >> alternative solution, like supplying a blank image or such. >> >> For certain corporate theme (more Java style) I have seen all dialogs >> >> redone e.g. with red X for cancel and green V for Ok. This should be >> >> "doable" in any interface style, Mac included. >> >> Riccardo
