Hi,
Fred Kiefer wrote:
Show "Enter" icon in default button only if NSInterfaceStyle is
NSNextStepInterfaceStyle or GSWindowMakerInterfaceStyle.
That icon looks alien in other interface styles such as
NSMacintoshInterfaceStyle:
The code look fine for me. I just wanted to raise the issue here to see if
there are any objections or improvement suggestions. Otherwise I will merge
this in a few days.
I don't like it as it is done. I like the concept of being able to
customzie those buttons, however this "That icon looks alien in other
interface styles such as NSMacintoshInterfaceStyle" is wrong in my
opinion. It is only true in the sense that a "macinthosh" doens't use
the enter key but has a focus ring (that is, it marks the enter button
differently). However "NSMacintoshInterfaceStyle" refers more to the
borad generic style: like top-menu and other details, not "clone mac".
A bit like WindowsStyle is at the end used for GTK or could be used for QT.
Just my opinion, maybe I should comment on the tread to find an
alternative solution, like supplying a blank image or such.
For certain corporate theme (more Java style) I have seen all dialogs
redone e.g. with red X for cancel and green V for Ok. This should be
"doable" in any interface style, Mac included.
Riccardo
