tlopex commented on code in PR #685:
URL: https://github.com/apache/tvm-ffi/pull/685#discussion_r3651346156
##########
rust/tvm-ffi/src/object.rs:
##########
@@ -50,6 +50,11 @@ unsafe impl<T: Send + Sync + ObjectCore> Sync for
ObjectArc<T> {}
pub unsafe trait ObjectCore: Sized + 'static {
/// the type key of the object
const TYPE_KEY: &'static str;
+ /// Whether every instance of this type has exactly `Self::type_index()`.
+ ///
+ /// A final type must never have a registered subtype.
+ #[doc(hidden)]
Review Comment:
`ObjectCore` is already public because downstream
`#[derive(Object)]`expansions need it; TYPE_FINAL is default-false and
#[doc(hidden)], so it remains internal derive metadata rather than a
user-facing API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
