tlopex commented on code in PR #685:
URL: https://github.com/apache/tvm-ffi/pull/685#discussion_r3651337868
##########
rust/tvm-ffi-macros/src/object_macros.rs:
##########
@@ -31,6 +31,11 @@ pub fn derive_object(input: proc_macro::TokenStream) ->
TokenStream {
let type_key = get_attr(&derive_input, "type_key")
.map(attr_to_str)
.expect("Expect #[type_key = \"<my_type_key>\"] attribute");
+ let type_final = match get_attr(&derive_input, "type_final") {
Review Comment:
Yes. false is the default, so a type whose C++ definition has _type_final =
false simply omits the attribute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
