oraluben commented on code in PR #300: URL: https://github.com/apache/tvm-ffi/pull/300#discussion_r2629781229
########## include/tvm/ffi/extra/cuda/unify_api.h: ########## @@ -0,0 +1,183 @@ +/* Review Comment: My intension is to provide a layer that user could use same code (error handling, etc.) to produce different binaries that uses driver API and runtime API. To archive that I think we need to define some of the basic types used, e.g. `CUdevice`/`int`, `CUstream`/`cudaStream_t`. For those underlying API calls, I agree with that we should make them internal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
