KEKE046 commented on code in PR #327:
URL: https://github.com/apache/tvm-ffi/pull/327#discussion_r2606888061
##########
python/tvm_ffi/error.py:
##########
@@ -121,19 +121,25 @@ def append_traceback(
The new traceback with the appended frame.
"""
- frame = self._create_frame(filename, lineno, func)
- return types.TracebackType(tb, frame, frame.f_lasti, lineno)
+ # Magic hack to prevent a circular reference
+ def create(tb: types.TracebackType | None, frame: types.FrameType,
lineno: int) -> types.TracebackType:
Review Comment:
Absolutely!
But I think anonymous lambda is a little not clear, as shown below
```py
(lambda frame: types.TracebackType(tb, frame, frame.f_lasti,
lineno))(self._create_frame(filename, lineno, func))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
