gemini-code-assist[bot] commented on code in PR #327:
URL: https://github.com/apache/tvm-ffi/pull/327#discussion_r2605832674
##########
python/tvm_ffi/error.py:
##########
@@ -121,19 +121,27 @@ def append_traceback(
The new traceback with the appended frame.
"""
- frame = self._create_frame(filename, lineno, func)
- return types.TracebackType(tb, frame, frame.f_lasti, lineno)
+ # we manually delete frame to avoid reference cycle, making it faster
to gc the locals inside the frame
+ try:
+ frame = self._create_frame(filename, lineno, func)
+ return types.TracebackType(tb, frame, frame.f_lasti, lineno)
+ finally:
+ del frame
Review Comment:
This `try...finally` block can mask exceptions. If `self._create_frame()` on
line 126 fails, the `frame` variable is never assigned. The `finally` block
will then execute, and `del frame` on line 129 will raise a `NameError`, hiding
the original, more informative error.
To fix this, the deletion must be safe. Using `locals().pop("frame", None)`
will remove the `frame` variable from the local scope only if it exists,
preventing the `NameError` and ensuring the original exception is correctly
propagated.
```suggestion
try:
frame = self._create_frame(filename, lineno, func)
return types.TracebackType(tb, frame, frame.f_lasti, lineno)
finally:
locals().pop("frame", None)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
