tqchen commented on code in PR #197:
URL: https://github.com/apache/tvm-ffi/pull/197#discussion_r2469707111
##########
include/tvm/ffi/reflection/registry.h:
##########
@@ -296,7 +296,7 @@ class ReflectionDefBase {
static_assert(std::is_base_of_v<ObjectRef, Class> ||
std::is_base_of_v<Object, Class>,
"Class must be derived from ObjectRef or Object");
if constexpr (std::is_base_of_v<ObjectRef, Class>) {
- auto fwrap = [func](const Class target, Args... params) -> R {
+ auto fwrap = [func](const Class& target, Args... params) -> R {
Review Comment:
I think it is probably fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
