tqchen commented on code in PR #197:
URL: https://github.com/apache/tvm-ffi/pull/197#discussion_r2467641918
##########
src/ffi/testing/testing.cc:
##########
@@ -261,11 +262,11 @@ TVM_FFI_STATIC_INIT_BLOCK() {
.def("testing.get_add_one_c_symbol",
[]() {
TVMFFISafeCallType symbol = __add_one_c_symbol;
- return reinterpret_cast<int64_t>(reinterpret_cast<void*>(symbol));
+ return reinterpret_cast<int64_t>(symbol);
})
.def("testing.get_mlir_add_one_c_symbol",
- []() {
- return
reinterpret_cast<int64_t>(reinterpret_cast<void*>(_mlir_add_one_c_symbol));
+ []() { //
Review Comment:
in some systems it is important to first cast function pointer to void* then
cast to int64_t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
