gemini-code-assist[bot] commented on code in PR #92:
URL: https://github.com/apache/tvm-ffi/pull/92#discussion_r2411601910
##########
cmake/Utils/AddLibbacktrace.cmake:
##########
@@ -43,15 +42,25 @@ function (_libbacktrace_compile)
SOURCE_DIR ${libbacktrace_source}
BINARY_DIR ${libbacktrace_prefix}
CONFIGURE_COMMAND
- "sh" "${libbacktrace_source}/configure"
"--prefix=${libbacktrace_prefix}" --with-pic
- "CC=${cmake_c_compiler}" "CPP=${cmake_c_compiler} -E"
"CFLAGS=${CMAKE_C_FLAGS}"
- "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}" "NM=${CMAKE_NM}"
"STRIP=${CMAKE_STRIP}"
- "--host=${MACHINE_NAME}"
+ "sh" #
+ "${libbacktrace_source}/configure" #
+ "--prefix=${libbacktrace_prefix}" #
+ "--with-pic" #
+ "CC=${cmake_c_compiler}" #
+ "CPP=${cmake_c_compiler} -E" #
+ "CFLAGS=${CMAKE_C_FLAGS}" #
+ "LDFLAGS=${CMAKE_EXE_LINKER_FLAGS}" #
+ "NM=${CMAKE_NM}" #
+ "STRIP=${CMAKE_STRIP}"
+ BUILD_COMMAND make -j
Review Comment:
While `make -j` enables parallel builds, it can be problematic as it
launches an unbounded number of jobs, potentially overwhelming the system,
especially on machines with many cores or in resource-constrained CI
environments.
A better approach is to let `ExternalProject` manage parallelism. If you
remove the `BUILD_COMMAND` line, `ExternalProject` will default to using `make`
and will automatically pass the correct parallel build flags (e.g., `-jN`) from
the main build process. This ensures a controlled parallel build that respects
the user's environment and settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
