gemini-code-assist[bot] commented on code in PR #116: URL: https://github.com/apache/tvm-ffi/pull/116#discussion_r2429667742
########## src/ffi/container.cc: ########## @@ -23,6 +23,7 @@ #include <tvm/ffi/container/array.h> #include <tvm/ffi/container/map.h> #include <tvm/ffi/container/shape.h> +#include <tvm/ffi/container/tensor.h> Review Comment:  This header `tvm/ffi/container/tensor.h` appears to be unused in this file. The type registrations are now centralized in `src/ffi/object.cc`, and this file doesn't seem to use any symbols from `tensor.h`. Removing unused includes improves build times and code maintainability. ########## src/ffi/tensor.cc: ########## @@ -29,6 +29,7 @@ namespace tvm { namespace ffi { TVM_FFI_STATIC_INIT_BLOCK() { + // register tensor type indices Review Comment:  This comment is slightly misleading. The registration of tensor type indices now happens in `src/ffi/object.cc`. This block registers FFI functions related to tensor containers. Clarifying the comment will help future developers understand the code's purpose more quickly. ```suggestion // register ffi functions for tensor containers ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
