tqchen opened a new pull request, #116: URL: https://github.com/apache/tvm-ffi/pull/116
This PR moves static inline registrations of objects in the object reg macros. Rationale: while the static inline based registration is convenient and removes the need for explicit registration this can cause extra space overhead for every dll that includes the header file even if the class is not used. Given that reflection::ObjectDef<T> already registers the type index and static type objects are predefined that we can control, we explicitly removes the static inline based reg trigger to we can save up possible binary space and reduce init logic. This does mean that when an Object is not registered through ObjectDef the dynamic casting mechanism won't work. But we are OK since expectation is most dynamic ObjectRef needs to do so for it to be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
